feat(tags): added KbqTagPrefix and KbqTagSuffix directives (#DS-4208) - #1885
Merged
Conversation
|
Visit the preview URL for this PR (updated for commit 6e67234): https://koobiq-next--prs-1885-gis6z24m.web.app (expires Sun, 16 Aug 2026 13:34:03 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: c9e37e518febda70d0317d07e8ceb35ac43c534c |
🚨 E2E tests failedReview the report for details. 💡 Comment |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR introduces explicit prefix/suffix content slots for KbqTag via new KbqTagPrefix/KbqTagSuffix directives, updates tag content projection/styling accordingly, and adds an Angular schematic migration to automatically preserve legacy icon placement behavior for existing consumers.
Changes:
- Added
kbqTagPrefix/kbqTagSuffixdirectives and updatedKbqTagcontent projection to use explicit slots (plus styling and docs). - Added the
tag-slotsmigration schematic (with tests) to mark legacy directly-projectedkbq-iconcontent askbqTagPrefix. - Updated examples, e2e fixtures, and relevant tests to use the new slot directives.
Reviewed changes
Copilot reviewed 25 out of 25 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tools/public_api_guard/components/tags.api.md | Public API snapshot updated for new slot directives and related metadata changes. |
| packages/schematics/src/migrations/tag-slots/schema.ts | Adds schematic options typing for the new tag-slots migration. |
| packages/schematics/src/migrations/tag-slots/schema.json | Declares CLI schema/options for the tag-slots migration. |
| packages/schematics/src/migrations/tag-slots/README.md | Documents intent, behavior, and usage of the tag-slots migration. |
| packages/schematics/src/migrations/tag-slots/index.ts | Implements template/inline-template migration that inserts kbqTagPrefix on legacy icons. |
| packages/schematics/src/migrations/tag-slots/index.spec.ts | Unit tests verifying migration behavior and idempotency. |
| packages/schematics/src/migrations.json | Registers the new migration for the upgrade pipeline. |
| packages/schematics/src/collection.json | Exposes the tag-slots schematic for manual invocation. |
| packages/docs-examples/components/tags/tag-with-icon/tag-with-icon-example.ts | Updates docs example to use explicit prefix/suffix slots. |
| packages/docs-examples/components/tags/tag-fill-and-style/tag-fill-and-style-example.ts | Updates docs example to use kbqTagPrefix for icons. |
| packages/docs-examples/components/select/select-custom-tag-content/select-custom-tag-content-example.ts | Updates select example tag template to use kbqTagPrefix. |
| packages/components/tags/tag.scss | Adds styles for .kbq-tag-prefix / .kbq-tag-suffix and deprecates legacy positional class usage. |
| packages/components/tags/tag.ru.md | Documents new slot directives and host-directive behavior (RU). |
| packages/components/tags/tag.module.ts | Exports the new slot directives via KbqTagsModule. |
| packages/components/tags/tag.en.md | Documents new slot directives and host-directive behavior (EN). |
| packages/components/tags/tag.component.ts | Adds KbqTagPrefix/KbqTagSuffix, updates projection selectors, and attaches KbqTagSuffix via hostDirectives where appropriate. |
| packages/components/tags/tag.component.spec.ts | Adds coverage for slot projection order and hostDirectives behavior. |
| packages/components/tags/e2e.ts | Updates e2e templates to use kbqTagPrefix for tag icons. |
| packages/components/select/select.component.spec.ts | Updates test markup to use kbqTagRemove. |
| packages/components/icon/e2e.ts | Updates icon e2e templates to use kbqTagPrefix within tags. |
| packages/components-dev/tag/template.html | Updates dev app templates to use kbqTagPrefix. |
| packages/components-dev/icon-adopted-stylesheets/template.html | Updates dev app templates to use kbqTagPrefix. |
| packages/components-dev/all/template.html | Updates dev app templates to use kbqTagPrefix across tag examples. |
| docs/guides/migration.ru.md | Adds migration guide section describing the breaking change and migration path (RU). |
| docs/guides/migration.en.md | Adds migration guide section describing the breaking change and migration path (EN). |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Contributor
Author
|
/approve-snapshots |
|
🔄 Updating snapshots. |
|
✅ Snapshots updated! |
lskramarov
approved these changes
Aug 12, 2026
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
artembelik
force-pushed
the
feat/DS-4208
branch
from
August 13, 2026 13:14
5d12fe9 to
2f2c7bd
Compare
🚨 E2E tests failedReview the report for details. 💡 Comment |
Contributor
Author
|
/approve-snapshots |
|
🔄 Updating snapshots. |
|
✅ Snapshots updated! |
NikGurev
approved these changes
Aug 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.